Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time - Hannah Mary #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stpatrickschild
Copy link

@stpatrickschild stpatrickschild commented Feb 10, 2020

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
1.) What did your data structure look like at first? Did this structure evolve over time? Why?

I have noticed that I get stuck in figuring out the code instead of trying to tackle each question at a time, so I have transition in writing the sudo code first. During this ride share, once I wrote the sudo code, I went back and forth in using Hashes and Arrays. Over time I realized that the 4 drivers were uniq and I can make that a uniq key and inside of that have nested Array of the data that correspond to that driver. So yes it evolve over time.
2.) What was your strategy for going through the data structure and gathering information?

Like I mentioned on question 1, first writing a sudo code, then really using paper and doing the math then gradually using those two things in writing code.
3.) What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful?

I stored cost per driver in a variable, and it was important to do that since that variable was going to be used through out question 2 and the questions following that. Once I have that in a variable, I can get the total cost, and also use it to compare which driver made the most money later on on question 4.

4.) What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it?

I ended up using .each do iteration. And as I answer these questions I realized that I could have used .map iteration for the Arrays and would have had variety iteration method. It was good to use it on cost per driver and storying that in different Array of total cost. I used .each method because it just was known method that came natural to me, that being said I know I only get better by applying different methods.

5.) Were some calculations easier than others? Why?

Too calculate the highest average rating was harder for me, the other were relatively easier. Even thought I have calculated the average rating prior, the method was harder to correct.

@stpatrickschild stpatrickschild changed the title Update worksheet.rb Time - Hannah Mary Feb 11, 2020
@kaidamasaki
Copy link

Ride Share

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables ✔️
Correctly creates and accesses arrays ✔️
Correctly creates and accesses hashes ✔️
Reasonably organizes large amounts of related data into nested arrays and hashes ✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods ✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods Didn't define methods.

Functional Requirements

Functional Requirement yes/no
To the terminal, the program outputs the correct number of rides each driver has given ✔️
... outputs the total amount of money each driver has made It looks like you commented out the line to do this.
... outputs the average rating for each driver ✔️
... outputs which driver made the most money ✔️
... outputs which driver has the highest average rating ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

It looks like you left in some debugging printing but aside from a couple of small things everything looks good!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation Your indentation was a little inconsistent, especially with your drivers.
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized Defining new methods could help organize/clarify your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants