Space - Nikki Vaughan #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jun 4, 2020
There was a problem hiding this comment.
Good job!
I liked how you organized your CSS into different files. It seems like you should go over controller filters another time and maybe look into how to use view partials to DRY up your code but overall you did well.
Your code was well organized and you have a good grasp of semantic HTML. 😃
Comment on lines
+3
to
+12
| def current_user | ||
| @current_user = User.find_by(id: session[:user_id]) | ||
| end | ||
|
|
||
| def require_login | ||
| if current_user.nil? | ||
| flash[:warning] = "A Problem occured: You must log in to do that" | ||
| redirect_back(fallback_location: "/") | ||
| end | ||
| end |
There was a problem hiding this comment.
I would probably combine these into a single method:
Suggested change
| def current_user | |
| @current_user = User.find_by(id: session[:user_id]) | |
| end | |
| def require_login | |
| if current_user.nil? | |
| flash[:warning] = "A Problem occured: You must log in to do that" | |
| redirect_back(fallback_location: "/") | |
| end | |
| end | |
| def require_login | |
| @current_user = User.find_by(id: session[:user_id]) | |
| if @current_user.nil? | |
| flash[:warning] = "A Problem occured: You must log in to do that" | |
| redirect_back(fallback_location: "/") | |
| end | |
| end |
Comment on lines
+10
to
+13
| @work = Work.find_by(id: params[:id]) | ||
| if @work.nil? | ||
| head :not_found | ||
| end |
There was a problem hiding this comment.
This sort of repeated logic should be placed into a controller filter.
| <% if flash[:details] %> | ||
| <ul> | ||
| <% flash[:details].each do |msg| %> | ||
| <% msg %> |
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?