space - kate #31
Open
space - kate #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users controller
Works controller
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
requested changes
Jun 5, 2020
There was a problem hiding this comment.
It looks like you had a difficult time with this.
Much of what was here was reasonable but it looks like you ran out of time while working on this. For example your controllers were of rather high quality.
Things to focus on to make sure you solidify your learning based on this are resources, controller filters and model relationships.
app/controllers/votes_controller.rb
Outdated
Comment on lines
23
to
30
| def edit | ||
| @vote = Vote.find_by(id: params[:id]) | ||
|
|
||
| if @vote.nil? | ||
| redirect_to root_path | ||
| return | ||
| end | ||
| end |
There was a problem hiding this comment.
Editing a vote is kind of a weird thing to do.
I would have omitted this action.
app/controllers/works_controller.rb
Outdated
Comment on lines
14
to
21
| @work = Work.find_by(id: params[:id]) | ||
| flash[:success] = "#{@work.category} added successfully" | ||
| if @work.nil? | ||
| flash.now[:error] = "Something happened. Book not added." | ||
| render :new, status: :bad_request | ||
| #head :not_found | ||
| return | ||
| end |
There was a problem hiding this comment.
I think you meant these flash messages to be in create.
app/controllers/works_controller.rb
Outdated
Comment on lines
29
to
34
| @work = Work.find_by(id: params[:id]) | ||
|
|
||
| if @work.nil? | ||
| redirect_to root_path | ||
| return | ||
| end |
There was a problem hiding this comment.
This kind of repeated logic should live in a controller filter.
app/models/user.rb
Outdated
Comment on lines
8
to
12
| def get_vote_count | ||
| #filter Vote Db by work_id = this.id | ||
| count = Vote.where(user_id: self.id).count | ||
| return count | ||
| end |
There was a problem hiding this comment.
This method is equivalent to doing user.votes.count.
app/models/work.rb
Outdated
Comment on lines
20
to
23
| if count > 0 | ||
| return false | ||
| end | ||
| return true |
There was a problem hiding this comment.
Suggested change
| if count > 0 | |
| return false | |
| end | |
| return true | |
| return count == 0 |
| <span class="spotlight__header--prefix">Media Spotlight</span> | ||
| <% if @work_spotlight != nil %> | ||
| <%= link_to @work_spotlight.title, work_path(@work_spotlight.id), class:'spotlight__link-to' %> by <%= @work_spotlight.creator%> | ||
| </h2> |
There was a problem hiding this comment.
I don't think you meant to leave this <h2> open if there was no spotlight.
test/models/user_test.rb
Outdated
Comment on lines
17
to
18
| # Assert | ||
| expect(found_user.username).must_equal "test_user" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?