Time - Haben #35
Open
Time - Haben #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 1, 2020
Comment on lines
+25
to
+27
| # Time Complexity:O(1) | ||
| # Space Complexity:O(1) | ||
| def add_first(value) |
| # Space Complexity: ? | ||
| def find_min | ||
| raise NotImplementedError | ||
| while (current = current.next) |
Comment on lines
+38
to
+40
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def search(value) |
Comment on lines
+69
to
+71
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def find_min |
There was a problem hiding this comment.
👍 , the space complexity is O(1) because you're not creating a new list.
Comment on lines
+83
to
+85
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def length |
There was a problem hiding this comment.
👍 , the space complexity is O(1) because you're not creating a new list.
Comment on lines
+126
to
+128
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def delete(value) |
There was a problem hiding this comment.
👍 , the space complexity is O(1) because you're not creating a new list.
Comment on lines
+148
to
+163
| # Time Complexity: o(n) | ||
| # Space Complexity: O(n) | ||
| # def reverse | ||
| # current = @head | ||
| # while current != nil | ||
| # temp = current.previous | ||
| # current.previous = current.next | ||
| # current.next = temp | ||
| # current = current.previous | ||
| # end | ||
| # temp = @head | ||
| # @head = @tail | ||
| # @tail = temp | ||
| # end | ||
|
|
||
| def reverse |
There was a problem hiding this comment.
👍 , the space complexity is O(1) because you're not creating a new list.
Comment on lines
+216
to
+218
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_first |
Comment on lines
+223
to
+225
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def add_last(value) |
Comment on lines
+239
to
+241
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_last |
There was a problem hiding this comment.
👍 , the space complexity is O(1) because you're not creating a new list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure if the reverse one was optional. After trying it, I decided to skip the test as I didn't want to waste more time at the last minute.