Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves-Yasmin-ride-share.rb #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

YasminM11
Copy link

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? I used array of hashes then i put arrays inside the hashes, changes have happened until i reached the final data structure, and this is because in the early stages of the program i could not access some nested data
What was your strategy for going through the data structure and gathering information? my strategy was to access my data in an organized way
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? total_money, most_money, driver_name to use it in the output
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? each do loop and i did not use map because i am not comfortable to use it yet
Were some calculations easier than others? Why? when i used built in functions such as .sum, .max

@YasminM11 YasminM11 changed the title Create ride-share.rb Leaves-Yasmin-ride-share.rb Aug 12, 2019
end

# -the average rating for each driver
average_rating = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to initialize average_rating since this value is set before you make the comparison.

total_money_index = money[:cost]
day_with_most_money = money[:date]
max_index = total_money_index.rindex(total_money_index.max)
puts "-Driver ##{money[:id]} has made the most money on #{day_with_most_money[max_index]}."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small thing, but make sure your indentation is consistent to promote readability and conform to ruby style guide.

end

# -the total amount of money each driver has made
total_money = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do no need to initialize total_money since this value is set before you make a comparison.

# - Which driver has the highest average rating?
#optional--For each driver, on which day did they make the most money?

trip_data = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data structure worked well for you and the logic for your calculations is clear. Consider how your calculations would change had you organized the data by driver.

trip_data = {
driver01: [{ride1}, {ride2},...],
driver02: [{ride1}, {ride2},...],
...
}

@beccaelenzil
Copy link

beccaelenzil commented Aug 15, 2019

Ride Share

What We're Looking For

Feature Feedback
Answers the comprehension questions yes -- try to add a bit more detail here so that you truly reflect on and learn from your process
Readable code with consistent indentation and reasonable code style yes
Outputs the correct number of rides each driver has given yes
Outputs the total amount of money each driver has made yes
Outputs the average rating for each driver yes
Outputs which driver made the most money yes
Outputs which driver has the highest average rating yes
Overall Great work on this assignment. Your code is clear and efficient. It is clear that the learning goals of working with enumerables and complex nested data structures were met. Review in line comments for some minor suggestions. You may also consider encapsulating some of the calculation functionality in methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants