-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaves-Yasmin-ride-share.rb #25
base: master
Are you sure you want to change the base?
Conversation
end | ||
|
||
# -the average rating for each driver | ||
average_rating = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to initialize average_rating since this value is set before you make the comparison.
total_money_index = money[:cost] | ||
day_with_most_money = money[:date] | ||
max_index = total_money_index.rindex(total_money_index.max) | ||
puts "-Driver ##{money[:id]} has made the most money on #{day_with_most_money[max_index]}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small thing, but make sure your indentation is consistent to promote readability and conform to ruby style guide.
end | ||
|
||
# -the total amount of money each driver has made | ||
total_money = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do no need to initialize total_money since this value is set before you make a comparison.
# - Which driver has the highest average rating? | ||
#optional--For each driver, on which day did they make the most money? | ||
|
||
trip_data = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This data structure worked well for you and the logic for your calculations is clear. Consider how your calculations would change had you organized the data by driver.
trip_data = {
driver01: [{ride1}, {ride2},...],
driver02: [{ride1}, {ride2},...],
...
}
Ride ShareWhat We're Looking For
|
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
.map
? If so, when? If not, why, or when would be a good opportunity to use it?