Leaves - Kristina and Georgia - PR #2

[krismosk]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up passenger and driver to have a has_many trip with trips. Trips belongs_to passenger and driver. We chose to set up these relationships in this format because, what the driver and passenger have in common is a trip and they can also have many trips. But the trip can only have one passenger and one driver.
Describe the role of model validations in your application	The validations require that certain data is present before any additional actions can be made. For example, you cannot create or update a passenger or driver with out the name & phone number, name & vin respectively.
How did your team break up the work to be done?	One partner worked on passenger model, controller, views, and tests and the other worked on driver. We both worked on trips.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize the business logic and testing because we felt that this was the most important learning goal for us. We chose to keep the CSS very minimal for sake of time.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained a lot of clarity on how models, controllers, and views all communicate with each other, we became more comfortable with branching, we also became more comfortable with migrations and seeding, even though we ran into issues with establishing foreign keys when we tried to deploy. We were able to resolve the deployment issues over the weekend and successfully deployed.
What is your Trello board URL?	https://trello.com/b/2QyMmbIv/ride-share-project
What is the Heroku URL of your deployed application?	https://super-uber.herokuapp.com
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We spent a lot of time in the beginning of the project using Trello to organize ourselves and it worked very well. We also prioritized learning git branching to improve workflow and maintained constant communication through Slack and we felt like we were on the same page the entire time.

[dHelmgren]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	yes
Answered comprehension questions	yes
Uses named routes (like _path)	yes
RESTful routes utilized	yes
Project Requirements
Table relationships	yes
Validation rules for Models	yes
Business logic is in the models	yes
Tests for validations	yes
Tests for relationships	yes
Tests for custom model methods	yes
Tests for controller actions	yes
Database is seeded from the CSV files	yes
Trello board is created and utilized in project management	yes
Heroku instance is online	yes
The app is styled to create an attractive user interface	yes
Overall	Good job on this! All of the learning goals were clearly met!