Branches, Angele and Kristy

[kristyh32]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Passenger and Driver both have many Trips, and Trips belong to both a Passenger and a Driver.
Describe the role of model validations in your application	Model validations made it impossible for the user to create new passengers or drivers without the required information.
How did your team break up the work to be done?	Yes, for some. We split up most of the functions of Passenger and Driver and worked together on Trips and styling and some model methods.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize making all of our links and paths go to the appropriate place and perform the function they were intended to perform. We de-prioritized some custom model methods in order to have time to make all of our links work.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We both learned a lot more about git branching and how useful it is for collaborative work.
What is your Trello board URL?	Trello
What is the Heroku URL of your deployed application?	Heroku
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both feel that we were very effective at splitting up work and tackling it separately.

[tildeee]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Project Requirements
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Tests for validations	x
Tests for relationships	x
Tests for custom model methods	untested per changed project reqs
Tests for controller actions	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Great work on this project, Kristy and Angele! Your controller tests are thorough and elegant, and the app code is well-written and uses best practices. It also has great details, like sorting, etc. Great work!

You two have one big bug: When deleting a driver or a passenger, if the driver or passenger still has trips associated with them, your app will not deal well with the views of the associated trips and drivers.

To reproduce:

1. Find a passenger (Passenger A) who has gone on at least one trip (Trip A, with Driver A)
2. Delete Passenger A
3. Go to the show page of Trip A, observe that it is broken
4. Go to the show page of Driver A, observe that it is broken

That being said, you all did a great job on this project. Well done, keep up the hard work!