Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Michaela & Emily #16

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

eaball35
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way Passengers & drivers both have many trips. Trips have one driver and one passenger. If a passenger or driver get deleted - all their trips are also deleted in our current design because our validations require them in every trip.
Describe the role of model validations in your application These assure inputs are present and valid and will allow for displaying error messages to user.
How did your team break up the work to be done? We broke it up into action items with tests, view items, error validations items, & misc requirements. Each of these were broken down for passenger, driver, and trip.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized CRUD actions and testing. We realized too late that we should have created some of our actions that are in controller (add rating, toggle active, etc) in the models instead. We did not have time to update this.
What was one thing that your team collectively gained more clarity on after completing this assignment? We gained clarity on appropriate routes and params passed in, and business model logic.
What is your Trello board URL? https://trello.com/b/BaiKNeiq/ride-share-rails
What is the Heroku URL of your deployed application? https://emily-michaela-rideshare-rails.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We both did a good job at error checking as the other person was driving. We could have practiced using git branches more in this project.

@jmaddox19
Copy link

Rideshare Rails

What We're Looking For

Great thoroughness of model tests! Site looks fully functional and very clean! Code is also very clean and clear! Great job y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants