Branches - Kelsey and Brianna #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Controller to Model
…, corrected active method
…input[type=submit])
…when that person is deleted
jmaddox19
reviewed
Oct 21, 2019
Comment on lines
+13
to
+17
| def convert_to_dollars(pennies) | ||
| if pennies.nil? | ||
| return 0 | ||
| else | ||
| (pennies / 100.0).round(2) |
There was a problem hiding this comment.
Love that y'all made a separate method for this! That said, the fact that this is repeated in three different classes is a sign that it probably belongs in its own class. It could be put in a class (maybe a new class called Money, for instance) and made a class method so that an instance of money isn't needed to call it.
| validates :driver, presence: true | ||
| validates :passenger, presence: true | ||
|
|
||
| def self.all_in_alpha_order |
Comment on lines
+38
to
+40
| @drivers = Driver.where(active: false) | ||
| @selected_driver = @drivers[rand([email protected])] | ||
| @trip.driver_id = @selected_driver.id |
There was a problem hiding this comment.
this is a good candidate for a model method
| # Assert | ||
| expect(new_driver.valid?).must_equal false | ||
| expect(new_driver.errors.messages).must_include :vin | ||
| expect(new_driver.errors.messages[:vin]).must_equal ["can't be blank"] | ||
| end | ||
| end | ||
|
|
||
| # Tests for methods you create should go here | ||
| describe "custom methods" do |
Rideshare RailsWhat We're Looking ForGreat job y'all! Love the video link. Haha. Also love that all the driver and passenger names are links everywhere, making for easy navigation. I left some inline comments as well, so please do check those out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rideshare-Rails
Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.
Comprehension Questions
trip belongs_to :driver,trip belongs_to :passenger,driver has_many trips,passenger has_many trips. We set them up this way because it was intuitive and manageable.Driver (name, vin)Passenger(name, phone_num),Trips(date, driver, passenger). They ensure that our methods cannot be executed without these parameters being fulfilled. All of our validations are set to have a presence oftrue