Speed up batchiepatchie by adding a date-range filter that defaults to 1 day #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,14 +28,16 @@ class Search extends React.Component { | |||
| static propTypes = { | |||
There was a problem hiding this comment.
Note: This PR has been split into smaller commits for easier review.
This PR is best reviewed with whitespace turned off.
| @@ -28,14 +28,16 @@ class Search extends React.Component { | |||
| static propTypes = { | |||
| loading: PropTypes.bool.isRequired, | |||
| qTemp: PropTypes.string.isRequired, | |||
| dateRange: PropTypes.string.isRequired, | |||
There was a problem hiding this comment.
I basically add dateRange wherever q appeared before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR has been split into smaller commits for easier review.
This PR dramatically speeds up batchiepatchie by adding a date filter. If you choose 1 day, queries that used to time out (because they were hardcoded to look back 30 days) will load in under 1 second.