Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set aw-server-rust in default config #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Dec 19, 2024

Important

Update default configuration in aw_qt/config.py to use aw-server-rust instead of aw-server.

  • Configuration:
    • Update default_config in aw_qt/config.py to use aw-server-rust instead of aw-server in both [aw-qt] and [aw-qt-testing] sections.

This description was created by Ellipsis for d0e49ee. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d0e49ee in 13 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_qt/config.py:8
  • Draft comment:
    Ensure that 'aw-server-rust' is compatible with the rest of the system and that any dependencies or configurations required for 'aw-server-rust' are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the default configuration to use 'aw-server-rust' instead of 'aw-server'. This change is consistent across both 'aw-qt' and 'aw-qt-testing' sections. The code correctly loads the configuration based on the 'testing' flag and assigns the 'autostart_modules'.

Workflow ID: wflow_ZDDN2mZ2otmMWsa2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare
Copy link
Member

Yeah, it might be time. What do you think?

@0xbrayo
Copy link
Member Author

0xbrayo commented Dec 20, 2024

Yep, it is. I guess lots of people are not even aware of the existence of the rust server. This should help fix that. Also maybe unpin aw-server and replace it with the aw-server-rust in the ActivityWatch profile page. I'll check the docs see if we they need an update too, or just mention that aw-server-rust is now the preferred server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants