✨ Improved statistics with reporting of CU used by fuzzed transactions #203
Conversation
… multiple programs
… Trident Features
st22nestrel
force-pushed
the
feat/CU_stats
branch
from
f1e4fc4 to
47e7a6e
Compare
There was a problem hiding this comment.
Please resolve mentioned changes.
I forgot to mention, please update the documentation accordingly.
I see that the FuzzTestExecutor is getting a bit messy. I'd like to improve this in a separate PR. Also, I don’t like that users can't choose which type of stats they'd like to see. I think we can resolve this by loading the config before fuzzing starts, which would also eliminate unnecessary overhead. Gonna work on it in separate PR.
| @@ -93,10 +111,60 @@ impl FuzzingStatistics { | |||
| successful: 1, | |||
| failed: 0, | |||
| failed_check: 1, | |||
| cu_used_max: 0, | |||
| cu_used_min: u64::MAX, | |||
There was a problem hiding this comment.
This could be misleading if every transaction fails, as it would show that the minimum amount was u64::MAX. I understand why you approached it this way, but I think we need to consider if there’s a better solution.
There was a problem hiding this comment.
I think checking for whether these values are still set to default in here f1e4fc4#diff-71ae76d79a6fc8fef2696e928840ebdd85005943030feaf457405706f81686c2R230 and if they are, outputting Not available or something like that would be ok. What do you think?
| match transaction_result { | ||
| Ok(result_with_metadata) => { | ||
| // We got metadata => transaction was either successful or returned with TransactionError | ||
| match result_with_metadata.result { |
There was a problem hiding this comment.
Personally, I would consider to first unwrap the Metadata and then based on the result (Ok , or Err), update the appropriate stats, but as I meantioned previously , this should be handled in executor not here.
… dispatch within the FuzzExecutor macro
st22nestrel
force-pushed
the
feat/CU_stats
branch
from
47e7a6e to
97df481
Compare
Description
This PR improves optional statistics logged at the end of fuzzing (introduced in #144). Function to process transaction with metadata was created, in order to be able to obtain CU used by the transaction. Reporting of minimum and maximum CU used for both failed and successful transactions was added.
Related Tickets & Documents
Related Issue #
Closes #
I clicked on "Allow edits from maintainers"