Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DG features sequence diagrams #260

Merged

Conversation

jiahui0309
Copy link

@jiahui0309 jiahui0309 commented Apr 14, 2024

Modified the sequence diagrams, added logging statements. Closes #224.

This PR does not include (as of latest commit):

  • any changes to activity diagrams

This PR includes:

  • logging
  • DG sequence diagrams
  • changes to DG implementation content for add, addnote, find
Screenshot 2024-04-14 at 9 50 17 PM Screenshot 2024-04-14 at 9 48 31 PM Screenshot 2024-04-14 at 9 48 44 PM Screenshot 2024-04-14 at 9 49 03 PM Screenshot 2024-04-14 at 9 49 22 PM

@drustanyjt
Copy link

@jiahui0309 why do the XYZCommandParser have crosses for object deletion but some of the other things (like the XYZCommand objects) do not? Should we add object deletions for the XYZCommand too after r is returned?

@jiahui0309
Copy link
Author

@drustanyjt okay! initially i was following the diagram they provided, but it seems reasonable to delete the obj after returning the result

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@tengcharmaine tengcharmaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiahui0309 jiahui0309 merged commit a16d989 into AY2324S2-CS2103T-F14-2:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit sequence diagram and activity diagram images
3 participants