Update dg v1.1 #26
Merged
Update dg v1.1 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
@Jayne1010 the "2ee37fa" commit ("Updated user guide") still has the wrong tense. You can try follow this https://stackoverflow.com/questions/1186535/how-do-i-modify-a-specific-commit . |
drustanyjt
requested changes
Mar 3, 2024
|
|
||
| * `exit` : Exits the app. | ||
| * `addnote patient i/T0123456A n/Patient has diabetes` : Add a note: 'Patient has diabetes' for the contact with the IC 'T0123456A' as shown in current list. |
There was a problem hiding this comment.
I think you have a typo, should it be "addnote patient i/..."?
| @@ -195,10 +172,9 @@ _Details coming soon ..._ | |||
|
|
|||
| Action | Format, Examples | |||
| -----------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------- | |||
| **Add** | `add n/NAME p/PHONE_NUMBER e/EMAIL a/ADDRESS [t/TAG]…` <br> e.g., `add n/James Ho p/22224444 e/[email protected] a/123, Clementi Rd, 1234665 t/friend t/colleague` | |||
| **Add** | `add n/NAME i/IC_NUMBER ag/AGE s/GENDER a/ADDRESS` <br> e.g., `add n/John Doe i/T0123456A ag/12 s/Male a/John street, block 123, #01-01` | |||
There was a problem hiding this comment.
I think the feature spec uses the term s/SEX instead of s/GENDER (since it's the letter 's')
Merged
Jayne1010
force-pushed
the
Updated-DG-v1.1
branch
from
d92f596 to
23fd148
Compare
Jayne1010
force-pushed
the
Updated-DG-v1.1
branch
from
23fd148 to
62eceed
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16