Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DG implementation for UI and show command #258

Merged
merged 9 commits into from
Apr 14, 2024
Merged

Update DG implementation for UI and show command #258

merged 9 commits into from
Apr 14, 2024

Conversation

Jayne1010
Copy link

@Jayne1010 Jayne1010 commented Apr 13, 2024 •
edited
Loading

Closes #227
Some issues:

  • Unable to make the class diagram for UI implantation (apparently all my class diagrams were unable to show up for some reason)
  • Design Consideration & Alternatives Considered different for the rest of the commands as the rest of commands were all repetitive
  • If so, maybe can do with @jiahui0309 to update the rest of the diagram

Following is the sequence diagram activity for the show command:

Screenshot 2024-04-14 at 9 43 47 PM Screenshot 2024-04-14 at 1 31 19 AM

jiahui0309
jiahui0309 requested changes Apr 14, 2024
View reviewed changes
Copy link

@jiahui0309 jiahui0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments on the content!

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
tengcharmaine
tengcharmaine reviewed Apr 14, 2024
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
tengcharmaine
tengcharmaine approved these changes Apr 14, 2024
View reviewed changes
Copy link

@tengcharmaine tengcharmaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayne1010 Jayne1010 requested a review from jiahui0309 April 14, 2024 14:40
jiahui0309
jiahui0309 approved these changes Apr 14, 2024
View reviewed changes
Copy link

@jiahui0309 jiahui0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayne1010 Jayne1010 merged commit 8637fae into AY2324S2-CS2103T-F14-2:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengcharmaine tengcharmaine tengcharmaine approved these changes

@jiahui0309 jiahui0309 jiahui0309 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update implementation section of developers guide
3 participants
@Jayne1010 @jiahui0309 @tengcharmaine