Merge pull request #151 from tengcharmaine/bug_fixesfor1.3

Fix ui display of personcard contents
AY2324S2-CS2103T-F14-2 · Apr 4, 2024 · d3482fd · d3482fd
2 parents 56f1b3e + 179b8cf
commit d3482fd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/main/java/seedu/address/ui/PersonCard.java b/src/main/java/seedu/address/ui/PersonCard.java
@@ -57,8 +57,12 @@ public PersonCard(Person person, int displayedIndex) {
         this.person = person;
         id.setText(displayedIndex + ". ");
         name.setText(person.getName().fullName);
-        phone.setText(person.getPhone().value);
-        email.setText(person.getEmail().value);
+
+        StringBuilder truncatedPhone = new StringBuilder();
+        phone.setText(truncatedPhone.append("Phone: ").append(person.getPhone().value).toString());
+
+        StringBuilder truncatedEmail = new StringBuilder();
+        email.setText(truncatedEmail.append("Email: ").append(person.getEmail().value).toString());
 
         String fullNote = person.getNote().value;
         int maxLineLength = 30; // Maximum length of each line before truncation
@@ -93,7 +97,9 @@ public PersonCard(Person person, int displayedIndex) {
         ic.setText(person.getIdentityCardNumber().value);
         age.setText(String.valueOf(person.getAge().value));
         sex.setText(person.getSex().value);
-        address.setText(person.getAddress().value);
+
+        StringBuilder truncatedAddress = new StringBuilder();
+        address.setText(truncatedAddress.append("Address: ").append(person.getAddress().value).toString());
         person.getTags().stream()
                 .sorted(Comparator.comparing(tag -> tag.tagName))
                 .forEach(tag -> tags.getChildren().add(new Label(tag.tagName)));

diff --git a/src/main/resources/view/PersonListCard.fxml b/src/main/resources/view/PersonListCard.fxml
@@ -40,15 +40,12 @@
         <Label fx:id="ic" styleClass="cell_small_label" text="\$ic" />
       </HBox>
       <HBox spacing="5" alignment="CENTER_LEFT">
-        <Label text="Phone:" styleClass="cell_small_label" />
         <Label fx:id="phone" styleClass="cell_small_label" text="\$phone" />
       </HBox>
       <HBox spacing="5" alignment="CENTER_LEFT">
-        <Label text="Address:" styleClass="cell_small_label" />
         <Label fx:id="address" styleClass="cell_small_label" text="\$address" />
       </HBox>
       <HBox spacing="5" alignment="CENTER_LEFT">
-        <Label text="Email:" styleClass="cell_small_label" />
         <Label fx:id="email" styleClass="cell_small_label" text="\$email" />
       </HBox>
       <HBox spacing="5" alignment="TOP_LEFT">