Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data type Category #17

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

dhlee03
Copy link

@dhlee03 dhlee03 commented Mar 16, 2024

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 75.25%. Comparing base (9da20be) to head (840f412).

Files Patch % Lines
...in/java/seedu/address/model/person/Categories.java 50.00% 1 Missing and 2 partials ⚠️
...main/java/seedu/address/model/person/Category.java 78.57% 2 Missing and 1 partial ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 60.00% 1 Missing and 1 partial ⚠️
.../java/seedu/address/storage/JsonAdaptedPerson.java 80.00% 1 Missing and 1 partial ⚠️
...c/main/java/seedu/address/model/person/Person.java 83.33% 0 Missing and 1 partial ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
- Coverage     75.26%   75.25%   -0.01%     
- Complexity      419      429      +10     
============================================
  Files            71       73       +2     
  Lines          1338     1386      +48     
  Branches        126      132       +6     
============================================
+ Hits           1007     1043      +36     
- Misses          301      307       +6     
- Partials         30       36       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhlee03 dhlee03 closed this Mar 16, 2024
@dhlee03 dhlee03 reopened this Mar 18, 2024
Copy link

@bachletuankhai bachletuankhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bachletuankhai bachletuankhai merged commit 6b56afb into AY2324S2-CS2103T-F12-4:master Mar 18, 2024
10 checks passed
@dhlee03 dhlee03 added this to the v1.2 milestone Mar 18, 2024
@bachletuankhai bachletuankhai linked an issue Mar 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change data format Add feature, add command
2 participants