Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to internal flash in example #8

Closed

Conversation

c1728p9
Copy link

@c1728p9 c1728p9 commented Dec 6, 2018

Set the storage type to TDB_INTERNAL and add the component FLASHIAP for all targets in mbed_app.json so new targets, such as the NRF52840_DK, work by default. This fixes #7.

Set the storage type to TDB_INTERNAL and add the component FLASHIAP
for all targets in mbed_app.json so new targets, such as the
NRF52840_DK, work by default.
@MarceloSalazar
Copy link

@dannybenor please review

@dannybenor
Copy link

I think it is not a good idea. This is an example of KVStore static API and not an example of internal memory usage.
Up to @MarceloSalazar to define the requirements for the examples, and because we have only one, not everything can be exercised

@c1728p9
Copy link
Author

c1728p9 commented Jan 23, 2019

Closing this. @MarceloSalazar and @dannybenor let me know if you want this re-opened.

@c1728p9 c1728p9 closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants