Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lisa.trace: Allow Trace(normalize_time=<float>, ...) #2154

Closed
wants to merge 1 commit into from
Closed

lisa.trace: Allow Trace(normalize_time=<float>, ...) #2154

wants to merge 1 commit into from

Conversation

douglas-raillard-arm
Copy link
Contributor

FEATURE

Allow normalizing time with an arbitrary offset. Use of True/False still have the same meaning as before.

@douglas-raillard-arm
lisa.trace: Allow Trace(normalize_time=<float>, ...)
d495d9b 
FEATURE

Allow normalizing time with an arbitrary offset. Use of True/False still
have the same meaning as before.
@douglas-raillard-arm
Copy link
Contributor Author

As discussed offline with @msrasmussen , instead of modifying the base Trace class, we should make TraceView more powerful and pass a post-processing function that allows modifying the dataframe returned by df_event() in arbitrary ways. Then we can build up on that with a Trace.with_time_offset() method simply creating a TraceView with a function applying an offset on the index.

@douglas-raillard-arm
Copy link
Contributor Author

Closing in favor of #2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@douglas-raillard-arm