Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set CARGO_CACHE_KEY #2558

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Properly set CARGO_CACHE_KEY #2558

merged 1 commit into from
Jan 7, 2025

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Jan 7, 2025 •
edited
Loading

Otherwise, CARGO_CACHE_KEY cannot pick CARGO_KEY which is set in the global env.

We now have a proper cache key:

Run actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
  with:
    path: ~/.cargo
    key: cargo-1.83.0-75ca44f76e7206d9e746dcf20c1484fead6387223a9b17403e4f686d596bf164-Linux-X64-build-static--12649015572
    restore-keys: cargo-1.83.0-75ca44f76e7206d9e746dcf20c1484fead6387223a9b17403e4f686d596bf164-Linux-X64-build-static-

instead of

Run actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9
  with:
    path: ~/.cargo
    key: -Linux-X64-build-static--12637496024
    restore-keys: -Linux-X64-build-static-

@vrabaud vrabaud requested a review from y-guyon January 7, 2025 09:46
@vrabaud vrabaud marked this pull request as ready for review January 7, 2025 09:46
@vrabaud
Properly set CARGO_CACHE_KEY
61b62a0 
Otherwise, CARGO_CACHE_KEY cannot pick CARGO_KEY which is set in
the global env.
@vrabaud vrabaud merged commit 4b16452 into AOMediaCodec:main Jan 7, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-guyon y-guyon y-guyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrabaud @y-guyon