Small Matrix (6x6, F) #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Jan 4, 2025
Add the implementation for the new small matrix (and small vector) types and their operators. Specialize for now for the most common type we need in accelerator physics, a 6x6, F-ordered, 1-indexed matrix.
ax3l
force-pushed
the
topic-small-matrix
branch
from
e55bf84 to
b23d94b
Compare
ax3l
commented
Jan 4, 2025
| // but many libs, e.g. PyTorch, do not | ||
| // support read-only and will raise | ||
| // warnings, casting to read-write | ||
| d["data"] = py::make_tuple(std::intptr_t(&m.template get<0>()), read_only); |
There was a problem hiding this comment.
@WeiqunZhang should .get honor the StartIndex in AMReX?
https://github.com/WeiqunZhang/amrex/blob/3fcfcce263bdfdb80297336284b3e9c07c85060d/Src/Base/AMReX_SmallMatrix.H#L392-L398
|
|
||
| auto sm = std::make_unique< SM >(); | ||
| auto * src = static_cast<T*>(buf.ptr); | ||
| std::copy(src, src + buf.size, &sm->template get<0>()); |
There was a problem hiding this comment.
@WeiqunZhang same as above (re: start index not honored in .get)
This comment was marked as resolved.
This comment was marked as resolved.
ax3l
force-pushed
the
topic-small-matrix
branch
from
d615266 to
44c82f0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+25
to
+29
| /* | ||
| make_SmallMatrix< float const, NRows, NCols, ORDER, StartIndex >(m, "float_const"); | ||
| make_SmallMatrix< double const, NRows, NCols, ORDER, StartIndex >(m, "double_const"); | ||
| make_SmallMatrix< long double const, NRows, NCols, ORDER, StartIndex >(m, "longdouble_const"); | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the implementation for the new small matrix (and small vector) types and their operators.
Specialize for now for the most common type we need in accelerator physics, a 6x6, F-ordered, 1-indexed matrix. (X-ref: ECP-WarpX/impactx#736, ECP-WarpX/impactx#743)
cc @cemitch99