Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake IPO Control #339

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix CMake IPO Control #339

merged 1 commit into from
Jul 17, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jul 16, 2024

pybind11::lto is only defined if CMAKE_INTERPROCEDURAL_OPTIMIZATION is not set in pybind11Common.cmake. Package managers like Spack use the latter.

@ax3l ax3l added bug Something isn't working install Build and installation bug: affects latest release Bug also exists in latest release version labels Jul 16, 2024
@ax3l ax3l force-pushed the fix-ipo-cmake branch 2 times, most recently from f6f4afd to 3bee188 Compare July 16, 2024 23:41
@ax3l ax3l mentioned this pull request Jul 16, 2024
1 task
@ax3l ax3l requested a review from EZoni July 17, 2024 00:01
CMakeLists.txt Outdated Show resolved Hide resolved
@ax3l ax3l self-assigned this Jul 17, 2024
`pybind11::lto` is only defined if `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
is not set in `pybind11Common.cmake`. Package managers like Spack
use the latter.
@ax3l ax3l merged commit cc8589f into AMReX-Codes:development Jul 17, 2024
13 of 14 checks passed
@ax3l ax3l deleted the fix-ipo-cmake branch July 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working install Build and installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant