Use bigint in HypreSolver test #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
hypre_bigint
branch
from
275d9b1 to
9d26517
Compare
WeiqunZhang
force-pushed
the
hypre_bigint
branch
from
9d26517 to
481d370
Compare
ax3l
reviewed
Jan 18, 2025
Src/Extern/HYPRE/AMReX_HypreSolver.H
Outdated
| // To generate global ids for Hypre, we need to remove duplicates on | ||
| // nodes shared by multiple Boxes with OverrideSync. So we need to use | ||
| // a type that supports atomicAdd. HYPRE_Int is either int or long | ||
| // long. The latter does not have native atomicAdd support in CUDA/HIP. |
There was a problem hiding this comment.
Maybe a last sentence, that unsigned long long is supported on CUDA/HIP, would describe the new logic fully.
ax3l
approved these changes
Jan 18, 2025
ax3l
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug when HYPRE_Int is long long. The issue was in the previous code the discard branch of
if constexprwas still checked by the compiler, because it's not in a function template, even though it's in a member function of a class template. We now turn the function into a template.