Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use abs for spherical 2d area #4256

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

zhichen3
Copy link
Contributor

@zhichen3 zhichen3 commented Dec 3, 2024

Summary

2d area in theta direction goes negative at theta=0 symmetry axis due to negative theta. But when we integrate from 0 to 2pi in phi, area orientation is the same regardless of +/- theta.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit 2f10b41 into AMReX-Codes:development Dec 3, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants