solve_bicgstab: cut use of s
#3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s implemented in MLCGSolverT class.
…to solve_bicgstab-avoid-use-of-s
…to solve_bicgstab-avoid-use-of-s
eebasso
changed the title
ss
…to solve_bicgstab-avoid-use-of-s
…to solve_bicgstab-avoid-use-of-s
WeiqunZhang
approved these changes
Nov 17, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
## Summary The MF named `s` seems to be an unnecessary usage of memory as the residue `r` can fulfill its roles in the algorithm. This PR replaces `s` with `r` and `LinComb` with `Saxpy` as appropriate. ## Additional background This PR is part of a larger request to improve `solve_bicgstab` and `solve_cg`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The MF named
sseems to be an unnecessary usage of memory as the residuercan fulfill its roles in the algorithm. This PR replacesswithrandLinCombwithSaxpyas appropriate.Additional background
This PR is part of a larger request to improve
solve_bicgstabandsolve_cg.