solve_bicgstab: use linop.make instead of MF constructor #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
approved these changes
Nov 9, 2023
|
Need to fix some warnings. |
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
…#3619) ## Summary This PR replaces the explicit use of MF constructors in ```MLCGSolverT<MF>::solve_bicgstab``` with calls to the `make` method of the linear operator associated with the MLCGSolverT object. ## Additional background The use of `MLLinOpT<MF>::make` allows for inheritance of MLCGSolverT without an override of `solve_bicgstab` even if the MF class lacks a constructor with the same arguments as those MultiFab. For the MLMG template classes, `make` should generally be used instead of explicit MF constructors. Another PR to change this in `solve_cg` will follow once this is fully vetted and approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the explicit use of MF constructors in
MLCGSolverT<MF>::solve_bicgstabwith calls to themakemethod of the linear operator associated with the MLCGSolverT object.Additional background
The use of
MLLinOpT<MF>::makeallows for inheritance of MLCGSolverT without an override ofsolve_bicgstabeven if the MF class lacks a constructor with the same arguments as those MultiFab. For the MLMG template classes,makeshould generally be used instead of explicit MF constructors. Another PR to change this insolve_cgwill follow once this is fully vetted and approved.