Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLEBABecLap: Support Robin BC at Domain Boundaries #3617

Merged
merged 1 commit into from
Nov 27, 2023
Merged

MLEBABecLap: Support Robin BC at Domain Boundaries #3617

merged 1 commit into from
Nov 27, 2023

Conversation

WeiqunZhang
Copy link
Member

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang requested a review from atmyers November 15, 2023 16:59
drummerdoc
drummerdoc approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@drummerdoc drummerdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to function correctly. Thanks Weiqun!

@WeiqunZhang WeiqunZhang merged commit 60b45bc into AMReX-Codes:development Nov 27, 2023
69 checks passed
@WeiqunZhang WeiqunZhang deleted the eb_robin branch November 27, 2023 21:57
guj pushed a commit to guj/amrex that referenced this pull request Dec 13, 2023
@WeiqunZhang @guj
MLEBABecLap: Support Robin BC at Domain Boundaries (AMReX-Codes#3617)
6e165c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drummerdoc drummerdoc drummerdoc approved these changes

@atmyers atmyers Awaiting requested review from atmyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @drummerdoc