use hipPointerAttribute_t.type as HIP is removing hipPointerAttribute_t.memoryType #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we use the |
|
Yes, HIP_VERSION_MAJOR can be used to maintain backward compatibility. |
|
Yes, something like that. In this case it's already in HIP specific code, so we don't need to test AMREX_USE_HIp.. |
rakesroy
force-pushed
the
fix_hip_memorytype
branch
from
de91083 to
ed9271a
Compare
|
I have updated this PR to to use .type when (HIP_VERSION_MAJOR >= 6), otherwise to use .memoryType for backwards compatibility. |
WeiqunZhang
reviewed
Oct 30, 2023
rakesroy
force-pushed
the
fix_hip_memorytype
branch
from
ed9271a to
379a58b
Compare
WeiqunZhang
approved these changes
Nov 1, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
…_t.memoryType (AMReX-Codes#3610) ## Summary This replaces hipPointerAttribute_t.memoryType with hipPointerAttribute_t.type. ## Additional background In ROCm6.0 hipPointerAttribute_t.memoryType will be removed from HIP. Instead hipPointerAttribute_t.type to be used. This is causing build failure in https://github.com/Exawind/amr-wind.git. hipPointerAttribute_t.type has been existing since ROCm5.5, so this change will be backward compatible till ROCm5.5. ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate Co-authored-by: Rakesh Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces hipPointerAttribute_t.memoryType with hipPointerAttribute_t.type.
Additional background
In ROCm6.0 hipPointerAttribute_t.memoryType will be removed from HIP.
Instead hipPointerAttribute_t.type to be used.
This is causing build failure in https://github.com/Exawind/amr-wind.git.
hipPointerAttribute_t.type has been existing since ROCm5.5, so this change will be backward compatible till ROCm5.5.
Checklist
The proposed changes: