Fix target_link_libraries calls w/ alias target

[nmnobre]

Hey @ax3l, @atmyers, @WeiqunZhang,

I think the guided tutorials are no longer building?
Feel free to edit with a better/shorter fix. :)

Cheers,
-Nuno

[WeiqunZhang]

It seems to build for me. What issues do you see?

$ amrex-tutorials/GuidedTutorials/HelloWorld/
$ mkdir build
$ cd build
$ cmake ..
$ mpiexec -n 4 ./HelloWorld
Initializing AMReX (24.12-14-gb3f67385e62f)...
MPI initialized with 4 MPI processes
MPI initialized with thread support level 0
AMReX (24.12-14-gb3f67385e62f) initialized
Hello world from AMReX version 24.12-14-gb3f67385e62f
AMReX (24.12-14-gb3f67385e62f) finalized

[WeiqunZhang]

I am using

commit 51fabc1563c3949a364e1a091d2632d4974662a8 (HEAD -> main, origin/main, origin/HEAD)
Merge: ffbfc5a d261a37
Author: Andy Nonaka <[email protected]>
Date:   Thu Dec 19 13:01:35 2024 -0800

    Merge pull request #148 from ajnonaka/main
    
    Add 2d to basic fft tutorial

[nmnobre]

I can't tell from your input/output for certain, but make sure CMake is not downloading AMReX and that you're using an existing AMReX installation with -DAMReX_ROOT=..., in which case you should see:

CMake Error at CMakeLists.txt:70 (target_link_libraries):
  target_link_libraries can not be used on an ALIAS target.

[WeiqunZhang]

I see. Let me try again later today.

[nmnobre]

Rebased to remove the updates to the CI workflows to install {cu,roc}SPARSE since @ajnonaka leapfrogged me. :)

[ax3l]

Do the tutorials have a specific dimensionality?

AMReX::amrex is for backwards compatibility and refers to the last-built spacedim (before, we could only build one -- keeping this target name around made transitions non-breaking/easier). But we have explicit AMReX::amrex_1d/AMReX::amrex_2d/AMReX::amrex_3d targets that we should now use.
https://github.com/AMReX-Codes/amrex/blob/041f225dc5c97a5e3baf2559046ceabffd75f002/Src/CMakeLists.txt#L8-L15

[ax3l]

Funny that we need MPI here at all, because if we need MPI, AMReX has to be built with MPI, which means MPI is already linked as a public transitive dependency in the AMReX::amrex_*d targets.

[nmnobre]

AMReX has to be built with MPI

Should we check for that? Or because we don't necessarily need MPI, do we just go with whatever the AMReX pkg we find already has (or has not)?