Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_installation.rst #2212

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Update python_installation.rst #2212

merged 5 commits into from
Dec 1, 2023

Conversation

willov
Copy link
Contributor

@willov willov commented Nov 27, 2023

On Python 3.11 and with openblas 0.3.24-2, the amici installer is unable to find "cblas.h". This is fixed by exporting the openblas path to BLAS_CFLAGS

On Python 3.11 and with openblas 0.3.24-2, amici installer is unable to find "cblas.h". This is fixed by exporting the openblas path to BLAS_CFLAGS
@willov willov requested a review from a team as a code owner November 27, 2023 14:18
@dweindl dweindl changed the base branch from master to develop November 27, 2023 14:35
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2212 (bc9b181) into develop (a41c906) will decrease coverage by 22.71%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head bc9b181 differs from pull request most recent head 1cdd865. Consider uploading reports for the commit 1cdd865 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2212       +/-   ##
============================================
- Coverage    76.45%   53.75%   -22.71%     
============================================
  Files           91       38       -53     
  Lines        15028     5659     -9369     
============================================
- Hits         11490     3042     -8448     
+ Misses        3538     2617      -921     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 53.75% <ø> (-0.03%) ⬇️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 81 files with indirect coverage changes

@dweindl
Copy link
Member

dweindl commented Nov 27, 2023

Thanks @willov.

@willov
Copy link
Contributor Author

willov commented Nov 27, 2023

@dweindl, the pull requests was perhaps a bit premature. While it resolves the install issues, there are still problems when trying to import amici. I will get back to you when/if we figure out how to solve the problem.

@Podde1 is also currently looking into the problem.

@dweindl
Copy link
Member

dweindl commented Nov 27, 2023

@willov : Maybe missing some BLAS_LIBS=-L/path/to/libopenblas.{a,so}?

@willov
Copy link
Contributor Author

willov commented Nov 28, 2023

Thanks! You are correct, export BLAS_LIBS="-L/usr/lib/ -lopenblas" solved it in my case (also with a --no-cache-dir). I will check if this also solved the problems for @Podde1, then I will issue another merge request.

@dweindl
Copy link
Member

dweindl commented Nov 28, 2023

Thanks! You are correct, export BLAS_LIBS="-L/usr/lib/ -lopenblas" solved it in my case (also with a --no-cache-dir). I will check if this also solved the problems for @Podde1, then I will issue another merge request.

👍

I will leave this PR open for now. Please update on this branch. Is -L/usr/lib/ required? I would have expected this directory to be included by default. I.e. is export BLAS_LIBS=-lopenblas not sufficient?
Right, --no-cache-dir is required with recent pip versions in case of linker errors.

@Podde1
Copy link

Podde1 commented Nov 28, 2023

I am have tested this in my environment now aswell. It was indeed sufficient to set export BLAS_LIBS=-lopenblas and exclude -L/usr/lib/.

exporting BLAS_LIBS  was also needed to get the amici package to be importable, in addition to BLAS_CFLAGS
@willov
Copy link
Contributor Author

willov commented Nov 28, 2023

export BLAS_LIBS=-lopenblas was indeed sufficient. I have updated the branch to also include instructions for exporting BLAS_LIBS.

@dweindl dweindl self-assigned this Nov 29, 2023
@dweindl dweindl merged commit c174c40 into AMICI-dev:develop Dec 1, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants