ARM64:dts:aspeed Add SPI LCD to Morocco DTS #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditional device tree change for adding spi1 LCD device tested: verified in Morocco platform Signed-off-by: modolaty <[email protected]>
aasboddu
approved these changes
Jan 30, 2025
mahkurap
requested changes
Feb 5, 2025
| oled@0 { | ||
| reg = < 0 >; // Chip select 0 | ||
| compatible = "ssd,ssd1322"; | ||
| spi-max-frequency = <1000000>; // Adjust the frequency as needed |
There was a problem hiding this comment.
remove the comment if 1MHz is the final value
supven01
requested changes
Feb 5, 2025
| @@ -188,6 +188,24 @@ | |||
| }; | |||
| }; | |||
|
|
|||
| #ifdef LCD_ENABLE | |||
There was a problem hiding this comment.
Can't use #ifdef. Both the drivers needed to be in memory. However, spi-txrx should be bind by default. In hpm_fpga_update.sh, we need to unbind the spi-txrx and bind flash driver just before updating the hpm fpga flash. After flash is done, unbind spi-flash driver and rebind spi-txrx similar to to how set-apml.sh is being done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional device tree change for adding spi1 LCD device
tested: verified in Morocco platform