Handle APML_ALERT assertion for SBRMI::[AlertSts] #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If there is core poison consumption error occured, the APML_ALERT will be toggled low, and no one to clear it to de-assert APML_ALERT. This commit clears the RMI_ALERTSTATUS [0x10 ~ 0x1f] [0x50 ~ 0x5f] which will clear the SBRMI::[AlertSts] bit and de-assert APML_ALERT. 2. Incremented the minor version by one to indicate there is a code change to ADDC for v14 release. 3. Handled error case if the family is not Turin/Genoa. Signed-off-by: Abinaya Dhandapani <[email protected]>
ojayanth
reviewed
Jan 27, 2025
| static_cast<uint32_t>(buffer)); | ||
| } | ||
|
|
There was a problem hiding this comment.
No cations required in case of read_register failure?
There was a problem hiding this comment.
In case of write failure , it will logged in the write_register() API.
So we dont require it to be logged here. Also we continue the ADDC functionality even if the write_register() call fails.
ojayanth
approved these changes
Jan 27, 2025
supven01
requested changes
Jan 27, 2025
|
|
||
| if (ret == OOB_SUCCESS) | ||
| { | ||
| if ((buffer & 0x0F) != 0) |
| "Socket%d: MCE Stat of SBRMIx[0x%x] is set to 0x%x\n", | ||
| socNum, alert_status[i], buffer); | ||
|
|
||
| buffer = buffer & 0xFF; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is core poison consumption error occured, the APML_ALERT will be toggled low, and no one to clear it to de-assert APML_ALERT. This commit clears the RMI_ALERTSTATUS [0x10 ~ 0x1f] [0x50 ~ 0x5f] which will clear the SBRMI::[AlertSts] bit and de-assert APML_ALERT.
Incremented the minor version by one to indicate there is a code change to ADDC for v14 release.
Handled error case if the family is not Turin/Genoa.