Update Stock_Fundamental.ipynb tutorial use new gymnasium library instead of deprecated gym library in SB3 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed table of contents to correctly link to sections - Modify StockTradingEnv to return back new expected number of variables (5, instead of 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design
With Stable Baselines3 transiting internally from OpenAI's Gym to Farama's Gymnasium (#99 ), the Stock_Fundamental.ipynb notebook should be updated to use Gymnasium for better long-term support. The StockTradingEnv's
stepfunction has been updated to return the appropriate number of values to the caller, and theresetfunction has been modified to accept a seed value as DummyVecEnv passes it.