Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure notification action #1251

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

shralex
Copy link
Collaborator

@shralex shralex commented Feb 7, 2025

The current implementation did not correctly placed the notification action -- it was placed as a step inside a clean-up job,
and as a result what was evaluated is only whether the clean up step succeeded or failed. Here we separate notification into its own job with explicit dependencies.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@copybara-service copybara-service bot merged commit ff59fb3 into main Feb 8, 2025
8 checks passed
@copybara-service copybara-service bot deleted the notify_failure_fix branch February 8, 2025 00:26
shralex pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants