Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CustomBufHandlers #2829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove CustomBufHandlers #2829

wants to merge 2 commits into from
+20 −217

Conversation

tokatoka
Copy link
Member

Before I do the final refactoring of event manager. I want to make things a bit cleaner.
CustomBufHandlers should be replaced with EventManagerHooks

@domenukk
Copy link
Member

Why?

@tokatoka
Copy link
Member Author

i think we already have discussion about this last year
#2438 (comment)

@domenukk
Copy link
Member

Still not fully convinced but yeah as I said back then, we can bring them back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokatoka @domenukk