Added new exception class to reveal more information to the user. Fix… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, it seems that the Actions runner has a different syntax for error messages, will fix and ship it back shortly. |
SeanBryan51
approved these changes
Oct 17, 2024
Co-authored-by: Sean Bryan <[email protected]>
Co-authored-by: Sean Bryan <[email protected]>
bschroeter
deleted the
34-pbs-scheduler-errors-are-not-output-to-the-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussions, a new class with the default behaviour to show more information to the user about the failed underlying shell command.
Added tests and fixed a small omission on the shell call itself.
Error message syntax can be changed, but for now it is:
Error $CODE: $STDERR\nWhich is pretty similar to the default, just with more information.
Programmatically, if a user is running into a situation where they are causing exceptions, their code should be made to be robust and handle these exceptions. HPCpy is doing what it should and communicating the error through Exceptions, rather than trying to handle them itself, which is going to be a massive can of worms as different HPC platforms have different setups... (i.e. some may not require a queue or project directive at all, where others do, even if there is only one possible option).