-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-industrial configuration with latest payu updates #42
Update pre-industrial configuration with latest payu updates #42
Conversation
I'll wait until #38 is merged and update this branch with the changes before trying to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes, some comments and some questions.
use updated module path for model executable Co-authored-by: Aidan Heerdegen <[email protected]>
Remove platform settings Co-authored-by: Aidan Heerdegen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! One more change required it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to merge, thanks @blimlim!
Thanks for the review! There will be a similar one soon with the same changes for the |
This pull request completes the pre-industrial half of #40. It modifies the configuration with the following changes:
shortpath
andproject
settingsmanifest: reproduce: exe: True
as in the OM2 configurations.It would be great to get a check over these changes, especially to confirm that the default values for several of the new
config.yaml
settings are suitable for ESM1.5.