JNA: ACE item category detection optimization #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ACE Advanced Medical is part of ACE, activeACEMedical == true AND activeACE == false is not a valid scenario. Checking for aceAdvMedItems branched under checking for aceItems. Should evaluate slightly faster.
Added additional commonly used ACE items to the aceItems array. This prevents the bug of ACE items getting stuck in the bipod tab of the arsenal.
zalexki
reviewed
May 12, 2018
| @@ -1032,6 +1032,14 @@ if (activeACE) then { | |||
| "ACE_DefusalKit", | |||
| "ACE_MapTools", | |||
| "ACE_Flashlight_MX991", | |||
| "ACE_Flashlight_MX991", | |||
There was a problem hiding this comment.
@AGM-114K duplication here
zalexki
suggested changes
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ACE Advanced Medical is part of ACE, activeACEMedical == true AND activeACE == false is not a valid scenario that has to be covered.
Checking for aceAdvMedItems branched under checking for aceItems. Should evaluate slightly faster.
Also added more ACE items to the gearList, preventing those items from getting stuck in the bipod tab.