Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restrict Link field with filter #28

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: Restrict Link field with filter #28

merged 1 commit into from
Oct 25, 2024

Conversation

IamSaiyyamChhetri
Copy link
Collaborator

@IamSaiyyamChhetri IamSaiyyamChhetri commented Oct 24, 2024 •
edited
Loading

  • Restrict the Link field with filters
  • Anywhere were link field is use
  • If any value is paste which bypass link filter in that case it will unset the Link field value.
  • Issue in 3.12 instance sample
Link_field_issue_sample.mp4
  • Fixes Sample
Restrict_Link_df.mp4

@IamSaiyyamChhetri
Copy link
Collaborator Author

Issue Link : 8848digital/erpnext#340

@aasif-patel
Copy link
Collaborator

@tinadn this issue also needs to be tested properly before merging.

@aasif-patel aasif-patel merged commit faaf5c2 into pre-prod Oct 25, 2024
13 of 14 checks passed
@aasif-patel
Copy link
Collaborator

aasif-patel commented Oct 25, 2024 •
edited
Loading

Worked now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinadn tinadn Awaiting requested review from tinadn

Assignees
No one assigned
Labels
add-test-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamSaiyyamChhetri @aasif-patel