forked from patw0929/react-intl-tel-input
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-intel input #1
Open
sunilchalla
wants to merge
69
commits into
500px:master
Choose a base branch
from
patw0929:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of unformatted value from previous state
changed 'no' to 'not'
update license to include 2019 as covered year.
Removed bash highlighting for npm/yarn commands in README
Update README.md
Update LICENSE
Use cross-env to solve the using environment variables issue across platforms
fixed bug with pasting number over another number
Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state
Due to this warning: package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
Remove package-lock.json
Bug fixes: * #302: Remove package-lock.json * #283: Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state * #300: fixed bug with pasting number over another number * #299: Use cross-env to solve cross platforms issue (scripts with node env variables) Docs: * #298: Update LICENSE * #297: Update README.md * #294: Removed bash highlighting for npm/yarn commands in README
Bug fixes: * #285: Update flag when defaultCountry value is changed
comment |
sunilchalla
commented
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Add optional onPhoneNumberFocus function
* refactor: no scss imports in components * refactor: story includes scss imports
* chore: add rc file to pin node version * chore: add semantic-release * ci: dry-run test * chore: add nvmrc for consistency * chore: commitlinting setup * ci: node v * ci: enable CI commitlinting
* feat: enable automated semantic releases * feat: release removing webpack BREAKING CHANGE: Remove webpack builds, babelize instead
* chore: combine prettier and eslint * chore: clean up eslint rules * chore: lint all * chore: clean up lint-staged hooks
* chore: flatting directory structure * fix: remove dependency on node-sass * chore: update storybook imports * docs: reset version, set contrib * docs: minor updates
* fix: make custom classes update instead of stack up * test: coverage for custom classes
Currently, we're checking for localStorage's presence but not its actual usability. In some scenarios, browsers can disallow `localStorage` to be called upon and in such cases, the library will hard crash. In this change, I added a catch statement to intercept these errors and return an empty string when `localStorage` cannot be called upon. - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [X] I have used ESLint & Prettier to follow the code style of this project. - [X] I have updated the documentation accordingly. - [X] I have added tests to cover my changes. - [X] All new and existing tests passed.
* build: set node to current maintenance version * build: node-sass bump * ci: minimum node * fix: typo
* ci: quick test/lint/build base * ci: coverage, coveralls * ci: lint, coveralls * fix: typo * ci: storybook deploy and dry deploy * ci: conditional release * ci: conditional release * chore: readme, travis cleanup * ci: add secrets
* ci: more attempts * ci: reverse to iterate * chore: bump storybook-deployer * ci: no actor? * ci: token name * ci: token name * revert: master deploys, nonmaster dryruns
* build: replaces node-sass with sass * chore: config
* Updated Contributions * Update README.md * Update README.md
* chore: bump eslint, fixall * chore: bump lint-staged * chore: update eslint-loader
* chore: unused eslint-plugin-security * chore: unused dotenv * revert: Revert "chore: unused eslint-plugin-security" This reverts commit e8c9d36. * chore: duplicate babel-core * chore: unused extract-text-webpack-plugin * revert: Revert "chore: duplicate babel-core" This reverts commit 73d961f. * chore: cross-env
* build: yarn berry * ci: yarn cache * chore: cov call syntax * chore: linker mode * chore: reuse n modules * chore: reuse n modules * ci: skip yarn install if cache hit * ci: coveralls split * ci: recursion
* chore: move website into own workspace * chore: resolve linting problems * chore: website missing deps, peers * chore: ci, artifacts * docs: refs to start
* build(npm): add TypeScript 4.3.5 w/ basic project setup * feat(types): add module definitions * feat(types): use jQuery for underscore.deferred According underscore.deferred's author, its API is very similar to jQuery's Deferred. * test(types): check definitions The .d.ts files aren't tested in jest. We’ll have to use tsd instead. * build(types): add definition file copy operation The tsc command won't help us here, but this will. - Manual copy: https://stackoverflow.com/a/56440335 - Script args: https://apple.stackexchange.com/a/228045 Using gulp hasn't been considered due to dependency bloat. * refactor(npm): split build script into readable fragments For easier maintenance. * chore(lint): add TypeScript configs * docs(readme): mention TypeScript support
* refactor: remove tsd usage * build: remove tsd configuration * docs: remove tsd mention * docs: remove complicated TypeScript usage These days, I imagine it's commonly understood how imports in TypeScript work. * chore: allow JSX in TSX * chore: apply eslint config to all TypeScript files * chore: allow console logging in TypeScript tests * chore: use multiline JSX props in TSX * refactor: satisfy eslint and prettier in TypeScript tests * build: bump typescript to 4.4.3 * refactor: remove unnecesary constants test * test: fix getCountryData object equality assertion * test: transfer getCountryData TS tests to JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue resolved..