This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
sanitised SQL input #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋 @bolshoytoster - we no longer accept vulnerability fixes through GitHub PRs. I can see that you correctly submitted a patch through our UI. The maintainer has been notified by e-mail and a comment has been left on the original GitHub Issue. Thanks for your continued work! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty URL:https://huntr.dev/bounties/2-other-akshayp282/QuizX/
⚙️ Description *
I sanitised input from the course add/edit/delete page
💻 Technical Description *
I used the
addslashesbuiltin addad in PHP 4 to sanitise thecnameparameter to the/QUIZ/partials/_handleCourse.phppage. This adds an escape () before any quotes which stops any potential SQL injection.🐛 Proof of Concept (PoC) *
Navigate to
/QUIZ/partials/_deletecourse.phpand enter' or ''=='. If you pressDelete, all courses will be deleted.🔥 Proof of Fix (PoF) *
If you repeat as above, you will recieve the
Course does not existerror.👍 User Acceptance Testing (UAT)
N/A