-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDLE-000] 배포 전 최종 수정사항 반영 #205
Conversation
Walkthrough
Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1)
Line range hint
16-22
: 크롤링 작업 모니터링 추가 제안크롤링 빈도가 증가함에 따라 작업 실행 상태와 성능을 모니터링하는 것이 중요합니다. 다음 사항들을 고려해보시기 바랍니다:
- 작업 성공/실패 로깅
- 크롤링 소요 시간 측정
- 수집된 데이터 수 기록
모니터링 구현에 도움이 필요하시다면 관련 코드를 생성해드릴 수 있습니다.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (3)
- idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1 hunks)
- idle-infrastructure/fcm/src/main/kotlin/com/swm/idle/infrastructure/fcm/common/config/FirebaseConfig.kt (0 hunks)
- idle-infrastructure/sms/src/main/kotlin/com/swm/idle/infrastructure/sms/auth/service/SmsService.kt (1 hunks)
💤 Files with no reviewable changes (1)
- idle-infrastructure/fcm/src/main/kotlin/com/swm/idle/infrastructure/fcm/common/config/FirebaseConfig.kt
✅ Files skipped from review due to trivial changes (1)
- idle-infrastructure/sms/src/main/kotlin/com/swm/idle/infrastructure/sms/auth/service/SmsService.kt
🧰 Additional context used
🔇 Additional comments (1)
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1)
16-16
: 크론 표현식 변경이 적절해 보입니다.스케줄링이 매일 오전 1시와 오후 1시로 변경된 것이 확인되었습니다. 피크 시간을 피하고 12시간 간격으로 데이터를 수집하는 것이 적절해 보입니다.
1. 📄 Summary
Summary by CodeRabbit
새로운 기능
버그 수정