Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDLE-000] 배포 전 최종 수정사항 반영 #205

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Conversation

wonjunYou
Copy link
Contributor

@wonjunYou wonjunYou commented Oct 23, 2024

1. 📄 Summary

  • 인증번호 sms의 안내 문구를 수정했습니다.
  • 크롤링 주기 하루 1회에서 하루 2회(1시, 13시로 변경)
  • 불필요 로그 제거, 파일 확장자 통일

Summary by CodeRabbit

  • 새로운 기능

    • 작업 스케줄링 구성 변경: 작업이 매일 오전 1시와 오후 1시에 실행되도록 조정되었습니다.
    • SMS 인증 메시지 포맷이 업데이트되어 사용자에게 발송되는 메시지가 변경되었습니다.
  • 버그 수정

    • 콘솔에 현재 작업 디렉토리를 출력하는 메서드가 제거되었습니다.

@wonjunYou wonjunYou self-assigned this Oct 23, 2024
Copy link

coderabbitai bot commented Oct 23, 2024

Walkthrough

CrawlingJobScheduler.kt 파일의 CrawlingJobScheduler 클래스에서 scheduleJob 메서드의 스케줄링 구성에 대한 수정이 이루어졌습니다. 크론 표현식이 "0 00 16 * * *"에서 "0 0 1,13 * * *"로 변경되어, 작업이 매일 오전 1시와 오후 1시에 실행되도록 설정되었습니다. FirebaseConfig.kt 파일에서는 printWorkingDirectory 메서드가 제거되었으며, initializeFirebaseApp 메서드는 변경되지 않았습니다. SmsService.kt 파일에서는 SMS 인증 메시지 형식이 업데이트되었습니다.

Changes

파일 경로 변경 요약
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt scheduleJob 메서드의 크론 표현식이 "0 00 16 * * *"에서 "0 0 1,13 * * *"로 변경됨.
idle-infrastructure/fcm/src/main/kotlin/com/swm/idle/infrastructure/fcm/common/config/FirebaseConfig.kt printWorkingDirectory 메서드가 제거됨. initializeFirebaseApp 메서드는 변경 없음.
idle-infrastructure/sms/src/main/kotlin/com/swm/idle/infrastructure/sms/auth/service/SmsService.kt CENTER_VERIFICATION_MESSAGE_FORMAT 상수가 "[케어밋] 센터 회원가입 인증번호는 %s 입니다."에서 "[케어밋] 요청하신 인증번호는 %s 입니다."로 변경됨.

Possibly related PRs

Suggested labels

✨기능, 🎯리팩토링


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wonjunYou wonjunYou added the 🎯리팩토링 리팩토링 및 고도화 이슈 label Oct 23, 2024
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1)

Line range hint 16-22: 크롤링 작업 모니터링 추가 제안

크롤링 빈도가 증가함에 따라 작업 실행 상태와 성능을 모니터링하는 것이 중요합니다. 다음 사항들을 고려해보시기 바랍니다:

  • 작업 성공/실패 로깅
  • 크롤링 소요 시간 측정
  • 수집된 데이터 수 기록

모니터링 구현에 도움이 필요하시다면 관련 코드를 생성해드릴 수 있습니다.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 3dcb4c3 and 7ff0ede.

📒 Files selected for processing (3)
  • idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1 hunks)
  • idle-infrastructure/fcm/src/main/kotlin/com/swm/idle/infrastructure/fcm/common/config/FirebaseConfig.kt (0 hunks)
  • idle-infrastructure/sms/src/main/kotlin/com/swm/idle/infrastructure/sms/auth/service/SmsService.kt (1 hunks)
💤 Files with no reviewable changes (1)
  • idle-infrastructure/fcm/src/main/kotlin/com/swm/idle/infrastructure/fcm/common/config/FirebaseConfig.kt
✅ Files skipped from review due to trivial changes (1)
  • idle-infrastructure/sms/src/main/kotlin/com/swm/idle/infrastructure/sms/auth/service/SmsService.kt
🧰 Additional context used
🔇 Additional comments (1)
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt (1)

16-16: 크론 표현식 변경이 적절해 보입니다.

스케줄링이 매일 오전 1시와 오후 1시로 변경된 것이 확인되었습니다. 피크 시간을 피하고 12시간 간격으로 데이터를 수집하는 것이 적절해 보입니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯리팩토링 리팩토링 및 고도화 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant