Remove unused mask code from rotozoom #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmmm, that mode switching code seems broken... |
|
For reference, the mask code (and the wonky mode switch) was added in 32blit/32blit-sdk@3b48d88 and disabled in 32blit/32blit-sdk@9306146, which I think were both the same PR, so this has basically never done anything useful. |
I'm not sure what was intended here, but "switch to `lores` when `DPAD_UP` is pressed, switch back on any other button change including `DPAD_UP` being released" probably isn't it.
Daft-Freak
force-pushed
the
patch-rotozoom-mask
branch
from
a7797d3 to
fd5539e
Compare
|
Emscripten action: "Cache already exists" I'm just going to wait and hope GitHub fixes itself... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the line that sets the mask has been commented out forever, this is just a waste of CPU cycles. (~7% on an RP2350)