Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy and description of the retrospective meeting for engineering #862

Merged
merged 18 commits into from
Jun 26, 2024

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented May 22, 2024

I also opened #863 as a follow-up, which is more about structure than content.

@sgibson91
Copy link
Member Author

Test failure is due to secrets not being available to PRs from forks

@haroldcampbell
Copy link
Contributor

@sgibson91 I've added some clarifications. Thanks for creating the first draft!

engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
@sgibson91
Copy link
Member Author

sgibson91 commented May 28, 2024

@haroldcampbell I disagree with your move towards engineers filling in the retrospective board during the meeting instead of before. It is really costly to get such a distributed team together on the same call and, therefore, we should maximise the time in that call for activity that is better served by synchronicity, i.e. discussions and talking to one another. Not "dead air" as we all quietly write things down by ourselves.

UPDATE: With a smaller, Euro-centric team for retrospectives, I feel less strongly about this.

Copy link
Contributor

@agoose77 agoose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice everyone. Thanks to you all <3

Here's some mostly-typography related comments.

engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
@sgibson91 sgibson91 marked this pull request as ready for review May 28, 2024 13:29
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once review comments has been considered, I think we should go with this as an initial improvement!

Thank you for working this @sgibson91!!

@agoose77 agoose77 self-requested a review June 20, 2024 11:30
engineering/workflow.md Outdated Show resolved Hide resolved
engineering/workflow.md Outdated Show resolved Hide resolved
@sgibson91
Copy link
Member Author

FYI, I cannot approve my own PR 😄

haroldcampbell and others added 8 commits June 26, 2024 10:27
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
Fixed formatting of {guilabel}
Emphasise ownership!

Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Sarah Gibson <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Angus Hollands <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Sarah Gibson <[email protected]>
@consideRatio consideRatio self-assigned this Jun 26, 2024
@consideRatio
Copy link
Contributor

I've iterated a bit on this:

  • added a brief backlog meeting section
  • refactored bullet points under the sprint board heading to the headings for meetings influencing the sprint board
  • misc details

I think we should just go for a merge - if additional work is proposed as part of this i think we should do another iteration in a fresh PR with less resolved comments etc.

@consideRatio consideRatio merged commit 4334425 into 2i2c-org:main Jun 26, 2024
1 of 2 checks passed
@consideRatio
Copy link
Contributor

Test failure seemed unrelated, so I also ignored it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants