[deployer exec root-homes]: wait for the pod to be ready before exec-ing into it #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgianaElena
added
the
deployer:skip-deploy
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@GeorgianaElena We have a Are you happy to close this in favour of that PR? Thank you for the work though! |
|
Sure! Also, I now just realized the importance of opening issues when a bug is found rather than going ahead and try to fix it. (I meant to open one but thought it will be a quick fix 🙄 ) |
|
I super-appreciate you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the command is not working as the pod is not ready immediately