Trigger rollout when any either configmap changes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeorgianaElena since its my first PR to this repo I felt it was suitable to ask for a review rather than self-merge. Is it correct that merging will just lead to a new version of the helm chart being published, and not cascade into a re-deploy as handled via https://github.com/2i2c-org/segmentation-challenge-deploy? |
@consideRatio, yes! Thank you! |
GeorgianaElena
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've not deployed this or similar, but I've tested that the helm chart renders as intended with
helm template ., showing new annotations with checksums.I've concluded that nginx needs an active restart/reload to adjust to a changed configmap, so restarting the pod makes sense when the nginx configmap changes - something that I wasn't confident on.