Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused detail-evaluation view #209

Merged
merged 2 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 0 additions & 89 deletions frx_challenges/web/templates/submission/evaluation.html

This file was deleted.

3 changes: 0 additions & 3 deletions frx_challenges/web/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,5 @@
name="collaborators-delete",
),
path("versions/<int:id>", versions.view, name="versions-view"),
path(
"evaluation/<int:id>", submissions.detail_evaluation, name="evaluation-detail"
),
path("", pages.home, name="home"),
]
11 changes: 1 addition & 10 deletions frx_challenges/web/views/submissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from ..forms import SubmissionForm
from ..md import MARKDOWN_RENDERER
from ..models import Collaborator, Evaluation, Submission
from ..models import Collaborator, Submission


@login_required
Expand Down Expand Up @@ -145,15 +145,6 @@ def edit(request: HttpRequest, id: int) -> HttpResponse:
)


@login_required
def detail_evaluation(request: HttpRequest, id: int) -> HttpResponse:
"""
View evaluation of a submission version
"""
evaluation = Evaluation.objects.filter(version__user=request.user, id=id)
return render(request, "submission/evaluation.html", {"evaluation": evaluation})


def _validate_collaborator(request: HttpRequest, submission_id: int):
"""
Check if current user is a collaborator on this submission
Expand Down