Address feedback from previous PRs #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Oct 29, 2024
helm-chart/templates/deployment.yaml
Outdated
| - echo | ||
| - "No admin users to add" | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
this should be after line 81, right?
There was a problem hiding this comment.
Yes, sorry, I closed the statement wrong
GeorgianaElena
force-pushed
the
feedback-fixes
branch
from
a2a3322 to
2041593
Compare
GeorgianaElena
force-pushed
the
feedback-fixes
branch
from
2041593 to
410b7a3
Compare
GeorgianaElena
changed the title
jnywong
pushed a commit
to 2i2c-org/frx-challenges-helm-chart
that referenced
this pull request
Nov 4, 2024
…b7a3 2i2c-org/frx-challenges#172 Merge pull request #172 from GeorgianaElena/feedback-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.