Skip to content

Commit

Permalink
Merge pull request #209 from 2i2c-org/remove-eval
Browse files Browse the repository at this point in the history
Remove unused detail-evaluation view
  • Loading branch information
yuvipanda authored Nov 26, 2024
2 parents 2a46b1c + c97eb33 commit b4839fa
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 102 deletions.
89 changes: 0 additions & 89 deletions frx_challenges/web/templates/submission/evaluation.html

This file was deleted.

3 changes: 0 additions & 3 deletions frx_challenges/web/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,5 @@
name="collaborators-delete",
),
path("versions/<int:id>", versions.view, name="versions-view"),
path(
"evaluation/<int:id>", submissions.detail_evaluation, name="evaluation-detail"
),
path("", pages.home, name="home"),
]
11 changes: 1 addition & 10 deletions frx_challenges/web/views/submissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from ..forms import SubmissionForm
from ..md import MARKDOWN_RENDERER
from ..models import Collaborator, Evaluation, Submission
from ..models import Collaborator, Submission


@login_required
Expand Down Expand Up @@ -145,15 +145,6 @@ def edit(request: HttpRequest, id: int) -> HttpResponse:
)


@login_required
def detail_evaluation(request: HttpRequest, id: int) -> HttpResponse:
"""
View evaluation of a submission version
"""
evaluation = Evaluation.objects.filter(version__user=request.user, id=id)
return render(request, "submission/evaluation.html", {"evaluation": evaluation})


def _validate_collaborator(request: HttpRequest, submission_id: int):
"""
Check if current user is a collaborator on this submission
Expand Down

0 comments on commit b4839fa

Please sign in to comment.