Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEFEST-1512 keys ui release 0.10.5 #599

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GEFEST-1512 keys ui release 0.10.5 #599

wants to merge 1 commit into from
+2 −2

Conversation

nbelyaev-2gis
Copy link

@nbelyaev-2gis nbelyaev-2gis commented Feb 6, 2025 •
edited
Loading

Pull Request description

Changelog

https://tsup.2gis.dev/gefest/keys-admin/changelog/0.10.3..0.10.5

В образах keys-ui используется node v22.

Issues

https://jira.2gis.ru/browse/GEFEST-1512

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@ostrovskiy2gis ostrovskiy2gis marked this pull request as ready for review February 7, 2025 08:46
@ostrovskiy2gis ostrovskiy2gis requested review from a team as code owners February 7, 2025 08:46
@dbelyaev-nsk
Copy link
Contributor

задача на проверку https://jira.2gis.ru/browse/ONPREM-1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbelyaev-2gis @dbelyaev-nsk